Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add config dict to cli #4424

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix: add config dict to cli #4424

merged 2 commits into from
Jan 19, 2024

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Jan 19, 2024

What does this PR address?

Fixes #(issue)

Before submitting:

@FogDong FogDong requested a review from a team as a code owner January 19, 2024 03:13
@FogDong FogDong requested review from aarnphm and removed request for a team January 19, 2024 03:13
@bojiang bojiang merged commit 758f954 into bentoml:1.2 Jan 19, 2024
37 of 40 checks passed
@Haivilo
Copy link
Contributor

Haivilo commented Jan 23, 2024

Do we need to add --config-dict? I think we can achieve it by using Heredoc like kubectl?

bentoml deployment create --config-file - <<EOF
...
EOF

This was supported in v1 https://docs.bentoml.org/en/latest/bentocloud/how-tos/deploy-bentos.html#id1

frostming pushed a commit that referenced this pull request Feb 1, 2024
* fix: add config dict to cli

Signed-off-by: FogDong <[email protected]>

* ci: auto fixes from pre-commit.ci

For more information, see https://pre-commit.ci

---------

Signed-off-by: FogDong <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants