Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support pydantic 2.9 #4960

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

frostming
Copy link
Contributor

@frostming frostming commented Sep 6, 2024

Signed-off-by: Frost Ming [email protected]

What does this PR address?

The new approach doesn't monkey patch globally and doesn't rely on internal members of pydantic.

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming requested a review from a team as a code owner September 6, 2024 01:49
@frostming frostming requested review from jianshen92 and removed request for a team September 6, 2024 01:49
Signed-off-by: Frost Ming <[email protected]>
pyproject.toml Outdated Show resolved Hide resolved
@frostming
Copy link
Contributor Author

The framework testing failures can be ignored as they are handled in dev/1.4 branch.

@frostming frostming changed the title fix: pin pydantic to <2.9 fix: support pydantic 2.9 Sep 6, 2024
@frostming frostming merged commit 72f38ce into bentoml:main Sep 6, 2024
46 of 51 checks passed
@frostming frostming deleted the fix/pydantic-compatibility branch September 6, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants