Merge pull request #176 from beproud/t173

#173 エンバグ修正
beproud · Mar 4, 2019 · ebec926 · ebec926
2 parents b14891b + ad44a40
commit ebec926
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/haro/slack.py b/src/haro/slack.py
@@ -39,6 +39,8 @@ def get_user_name(user_id):
     """
     users = get_users_info()
     profile = users.get(user_id)
+    if not profile:
+        return
     return profile['name']
 
 

diff --git a/tests/test_slack.py b/tests/test_slack.py
@@ -26,6 +26,16 @@ def test_get_user_name(self, target):
 
         assert name == actual
 
+    def test_get_user_name_with_none(self, target):
+        """存在しないユーザー名であればNoneが返る事
+        """
+        user_id = 'U41NH7LFJ'
+
+        with patch('haro.slack.get_users_info', return_value={}):
+            actual = target(user_id)
+
+        assert None is actual
+
 
 class TestGetUserDisplayName: