Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fir header dialog information into min width #569

Conversation

ctzsnooze
Copy link
Member

@ctzsnooze ctzsnooze commented Feb 28, 2022

fixes #568

@McGiverGim expressed concern that at minimum window width, not all the information in the header dialog was visible.

I rearranged things a bit - margins, rearranging the header, that sort of thing, and it all now fits quite neatly.

The minimum window width is now 930px, a meaningful increase over the previous minimum of 740px. The minimum width could be as small as 900px and still look OK (see below), but at 930px the header dialog sits symmetrically above the main graphical area and looks good. It should still fit into most computer screens at 930px.

Here is an image showing how it looks at 930px width.

redraft min window

This is the previous appearance at about the same width.

same size previously

This is the new appearance but with a min-width of 900px (this is not the value in the PR, but I included it here in case you think it might be better like that).

We don't really need all the white space at the top but I couldn't figure out how to get rid of it.

moin width 900

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ctzsnooze ctzsnooze self-assigned this Feb 28, 2022
@haslinghuis haslinghuis added this to the 3.6.0 milestone Feb 28, 2022
@blckmn
Copy link
Member

blckmn commented Mar 1, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit ad79fbc into betaflight:master Mar 1, 2022
@asizon
Copy link
Member

asizon commented Mar 1, 2022

Thankyou @ctzsnooze @haslinghuis!!

@ctzsnooze ctzsnooze deleted the adjust-header-dialog-information-to-fit branch September 27, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log header does not adapt to the minimum resolution
4 participants