Seekbar more metrics #635
Seekbar more metrics #635
Conversation
This comment has been minimized.
This comment has been minimized.
|
AUTOMERGE: (FAIL)
|
|
More code smells to solve 😋 |
|
Now it seems to be accepted by SonarCloud. |
|
We have squash and merge, so all good. |
This comment has been minimized.
This comment has been minimized.
|
the default window size at launch always pushes this off-view for me. thinking the entire bar needs some auto-flow/sizing work :( thoughts @haslinghuis ?? |
I want to put it into the seekbar like it's done in the spectrum analyzer. But I need to get a grasp of how the canvases work before -> can we leave it as is for now and I change it to something better in another PR next week (I'm on vacation right now)? |
(like its done in the spectrum plots)
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
|
for others to review: mouse-over: upon modify (bold outline then fades to normal): |
|
please mark any of the above suggestions resolved if they are indeed resolved. |
| @@ -314,6 +315,36 @@ function BlackboxLogViewer() { | |||
| } | |||
| } | |||
|
|
|||
| function renderSeekBarPicker(){ | |||
| var | |||
There was a problem hiding this comment.
Slipped through Sonarcloud bot :)
This allows showing different metrics in the searchbar for spotting spots of interrest in longer logs easier.
The dropdown to select those is right beside the workspace selection. The chosen mode will survive picking a different log from a file but will get reset to average throttle when loading a new file.
The following modes have been implemented (so far)
Average motor throttle: this is the old behavior
maximum Stick input: highest absolute value of (roll/pitch/yaw) (find snap-moves)
maximum Motor differential: difference of highest and lowest motor output (find fast moves/desyncs - thanks to Zoggbarr for the suggestion)
ref: #634