Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add motor_poles to header render #647

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

nerdCopter
Copy link
Member

  • add motor_poles to header render (index.html)

motor-poles

happy to re-arrange if desired

@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nerdCopter
Copy link
Member Author

@BrandonsBakedBeans

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

255 motor poles 🤯

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Aug 12, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@BrandonsBakedBeans
Copy link

I tested it and the header for TPA went away but other than that I welcome this!
bbe 3 6 tpa
bbe 3 7 tpa

@haslinghuis haslinghuis merged commit e12edcf into betaflight:master Aug 12, 2023
@haslinghuis haslinghuis added this to the 3.7.0 milestone Aug 12, 2023
@nerdCopter
Copy link
Member Author

I tested it and the header for TPA went away but other than that I welcome this!

#649 fixes that.
BBE master is out of sync with firmware; quite a few updates are needed. Use a future nightly if you like.

@nerdCopter
Copy link
Member Author

255 motor poles exploding_head

😆 UINT8_MAX in firmware is the only reason i did that.

src/main/cli/settings.c:864: { PARAM_NAME_MOTOR_POLES, VAR_UINT8 | MASTER_VALUE, .config.minmaxUnsigned = { 4, UINT8_MAX }, PG_MOTOR_CONFIG, offsetof(motorConfig_t, motorPoleCount) },

@nerdCopter nerdCopter deleted the 20230812_motor_poles branch January 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants