Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip fieldsList_e init if it already has fields #706

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

mituritsyn
Copy link
Contributor

Fix for small issue when "Disabled fields" list is stacked on each opening

image

haslinghuis
haslinghuis previously approved these changes Feb 18, 2024

This comment has been minimized.

@nerdCopter
Copy link
Member

  • i dont think this is the proper fix. if you open LOG A with no disabled fields, then open LOG B with some disabled fields, it simply keeps LOG A results.
  • proper fix would be clear the results, then continue the normal process.

@mituritsyn
Copy link
Contributor Author

  • i dont think this is the proper fix. if you open LOG A with no disabled fields, then open LOG B with some disabled fields, it simply keeps LOG A results.
  • proper fix would be clear the results, then continue the normal process.

thanks for the tip. with emptying the list there is no issues with different logs in one session

js/header_dialog.js Outdated Show resolved Hide resolved

This comment has been minimized.

Co-authored-by: Mark Haslinghuis <[email protected]>
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you both. committed @haslinghuis ' suggestion and approved.

Copy link

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 62ade97 into betaflight:master Feb 19, 2024
5 checks passed
@mituritsyn mituritsyn deleted the fix_disabled_fields branch February 19, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants