Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor access modifiers in base classes #1609

Closed
jaybyrd42 opened this issue Sep 19, 2024 · 2 comments
Closed

Refactor access modifiers in base classes #1609

jaybyrd42 opened this issue Sep 19, 2024 · 2 comments
Milestone

Comments

@jaybyrd42
Copy link

Add possibility to override OnMouseDown, OnMouseUp and other related event handlers and reuse logic from those overriden methods in Classes derived from LiveChartsCore.Chart by changing InvokePointerDown, InvokePointerMove, InvokePointerUp, InvokePointerLeft... access modifiers to protected internal

@jaybyrd42
Copy link
Author

Possibly refactor all internal modifers to protected internal.

Having internal access modifiers when using this library as Nuget package hinders modification

beto-rodriguez added a commit that referenced this issue Oct 11, 2024
Thiws commit changes all the relavant internal modifiers to protected internal.
@beto-rodriguez beto-rodriguez modified the milestones: rc-3, rc-4 Oct 11, 2024
@beto-rodriguez
Copy link
Owner

I like this idea; I changed most of the internal methods to protected internal (at least the methods that make more sense).

This will be included in the next version, I hope this is enough, but let me know if something is not accessible enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants