Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make Uno.WinUI conditional to Uno targets #1540

Conversation

jeromelaban
Copy link
Contributor

This change avoids a duplicate resources issue that has been fixed in microsoft/microsoft-ui-xaml#8857.

While upgrading WinAppSDK would also fix the issue, it's best to remove the dependency altogether.

Without this fix, the error can appear as follows:

ERROR: PRI175: 0x80073b0f - Processing Resources failed with error: Duplicate Entry.
ERROR: PRI277: 0x80073b0f - Conflicting values for resource 'Files/Uno.UI.Toolkit/Themes/Generic.xbf'

This avoids a duplicate resources issue that has been fixed in microsoft/microsoft-ui-xaml#8857.

While upgrading WinAppSDK would also fix the issue, it's best to remove the dependency altogether.
@beto-rodriguez beto-rodriguez changed the base branch from master to dev July 12, 2024 16:38
@jeromelaban
Copy link
Contributor Author

@beto-rodriguez thanks for adjusting! So the issue here is caused by the fact that there's no .NET SDK explicitly installed, which picks up the version coming from the GA agents, and changed since the last build.

There are multiple ways to do this, but the best is to explicitly install .NET in order to only have the version that was used at the time (net6 in this case). In some cases though, even installing .NET before hand does not work, and specifying an alternate install folder can help.

@beto-rodriguez beto-rodriguez merged commit 6e4dc01 into beto-rodriguez:dev Jul 12, 2024
1 of 5 checks passed
@beto-rodriguez
Copy link
Owner

So the issue here is caused by the fact that there's no .NET SDK explicitly installed

Thanks, for the tip @jeromelaban, I will improve that in another PR.

For now, I will merge this PR. thanks for the PR!

@Youssef1313
Copy link

@beto-rodriguez Could we have a new release with the fix from this PR?

@beto-rodriguez
Copy link
Owner

@Youssef1313 should be now available at the latest release, sorry for the delay!

https://www.nuget.org/packages/LiveChartsCore.SkiaSharpView.Uno.WinUI/2.0.0-rc2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants