Remove obsoletes #1625
Merged
Remove obsoletes #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The obsolete properties `TextBrush` and `SeparatorsBrush` were removed from the `CoreAxis` class. These properties had been previously marked as obsolete and renamed to `LabelsPaint` and `SeparatorsPaint`, respectively. The removal of these properties helps to clean up the codebase by eliminating deprecated code.
Removed MaxOuterRadius property and replaced it with OuterRadiusOffset across the codebase: - Updated `1.6.paint tasks.md` to remove `MaxOuterRadius` from `PieSeries<int>` initialization. - Modified `Hello.razor` to replace `MaxOuterRadius` with `OuterRadiusOffset` in `PieChart.Series` initialization. - Removed `MaxOuterRadius` property and its methods from `CorePieSeries.cs`. - Updated `IPieSeries.cs` to remove `MaxOuterRadius` from the interface definition.
Added comments indicating that the PathGeometry class is obsolete but still in use within the HeatPathShape class. Included a ToDo comment suggesting an update to use the AreaGeometry class instead. Added a pragma directive to disable compiler warning CS0612 for the obsolete PathGeometry.
Renamed `GaugeBuilder` to `GaugeGenerator` in documentation and added links to gauge samples. Removed detailed code examples and `IGaugeBuilder` interface. Deleted `GaugeBuilder.cs` file, replacing its functionality with `GaugeGenerator.BuildSolidGauge`.
Updated `citiesSeries` in `series.md` to use a new mapping function that returns `Coordinate` objects with the `index` as the X coordinate and `city.Population` as the Y coordinate. Removed obsolete properties (`PrimaryValue`, `SecondaryValue`, `TertiaryValue`, `QuaternaryValue`, and `QuinaryValue`) from `ChartPoint.cs` to enforce the use of the `Coordinate` property.
Reformatted `using` directives for better readability. Removed obsolete `Index` property from `ChartPointContext` class. Users should now use `ChartPoint.Index` instead.
The documentation for tooltip point text has been updated to include the `ToolTipLabelFormatter` property in addition to the existing `YToolTipLabelFormatter` and `XToolTipLabelFormatter` properties. This change clarifies that users can now use any of these three properties to define the text displayed in tooltips for a given point, providing more flexibility in customizing tooltip content.
Refactored namespaces in IPieSeries.cs by removing `using System;` and adding `using LiveChartsCore.Drawing;` and `using LiveChartsCore.Measure;`. Updated Series.cs by removing obsolete `DataPointerHover` and `DataPointerHoverLost` events, replacing them with `ChartPointPointerHover` and `ChartPointPointerHoverLost`. Adjusted `OnPointerEnter` and `OnPointerLeft` methods to reflect these changes.
The LegendShapeSize property has been removed from the Series<TModel, TVisual, TLabel, TDrawingContext> class. This property was previously used to get or set the size of the legend shape and was replaced by the MiniatureShapeSize property.
The entire MIT license header, using directives for System and LiveChartsCore.Drawing, namespace declaration LiveChartsCore.SkiaSharpView.Painting, and the obsolete PaintTask class have been removed from PaintTask.cs. This effectively clears the file of all its previous content.
The `TappedCommand` property has been removed from the `CartesianChart`, `PieChart`, and `PolarChart` classes. This property was marked as obsolete and has been replaced by the `PressedCommand` and `ReleasedCommand` properties. The `PointerMoveCommand` property has been removed from the `CartesianChart`, `PieChart`, and `PolarChart` classes. This property was marked as obsolete and has been replaced by the `MovedCommand` property. These changes clean up the codebase by removing deprecated properties that were previously marked with `[Obsolete]` attributes.
The entire content of the `LegendBindingContext.cs` file has been removed. This includes the MIT license header, all using directives, and the complete `LegendBindingContext` class definition. The class contained properties for series, font family, font size, font weight, font style, text brush, and background.
Updated ChangingPaintTasks.cs to use SKCartesianChart instead of the obsolete TestCartesianChartView. Removed TestCartesianChartView.cs as it is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the library for the first stable release.
Fixed issues
Breaking changes:
All properties and methods marked as obsolete in all previous preview versions are now removed.