Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs review #1630

Merged
merged 25 commits into from
Oct 11, 2024
Merged

Docs review #1630

merged 25 commits into from
Oct 11, 2024

Conversation

beto-rodriguez
Copy link
Owner

No description provided.

Removed the parameter `true` from `UseSkiaSharp` method calls in `1.2.install.md` and `MauiProgram.cs`, simplifying them to `UseSkiaSharp()`.
separate variable svg from static svg shapes
This reduces boilerplate mainly, but could also improve performance in some cases.
makes Series.Values property model-typed
now that series are model-type-aware, we can reduce the biolerplate code
and use collection expressions in the Series.Values property, for example:
Values = new double[] { 2, 5, 4 } changes to Values = [2, 5, 4]
Changed csharp_style_expression_bodied_methods from `false` to
`when_on_single_line:warning` to prefer single-line expression-bodied
methods. All other settings remain unchanged.
A lot of changes in this commit, the idea is to
simplify all the samples exposed in the web site,
it abuses of collection expressions, and removes
MVVM ObservableObject when not necessary.
Added a tip section to the documentation to help users troubleshoot issues where the chart might not be showing. The tip suggests that the layout might be hiding the control and recommends explicitly setting the size of the control (Width and Height). It also references related issues #1483 and #1581 for further assistance.
- Streamlined MVVM explanation and added resources in `CommunityToolkit.Mvvm` docs.
- Added new sections in `template.md` for title, image, and `ObservablePoint` usage.
- Updated `genericSampleHeader.md` and `genericSampleJustGifHeader.md` to mention C# 12 and `CommunityToolkit.Mvvm`.
- Updated `genericSampleSimpleHeader.md` to include C# 12 features and a link to the toolkit.
Corrected "tread" to "thread" in multiple files for accuracy.
Added a centered image in `template.md` for better visuals.
Fixed "treated" spelling in `PieChartExtensions.cs` method params.
@beto-rodriguez beto-rodriguez merged commit 876d1b6 into dev Oct 11, 2024
4 checks passed
@beto-rodriguez beto-rodriguez deleted the docs-review branch October 11, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant