-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs review #1630
Merged
Merged
Docs review #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the parameter `true` from `UseSkiaSharp` method calls in `1.2.install.md` and `MauiProgram.cs`, simplifying them to `UseSkiaSharp()`.
separate variable svg from static svg shapes
This reduces boilerplate mainly, but could also improve performance in some cases.
makes Series.Values property model-typed
now that series are model-type-aware, we can reduce the biolerplate code and use collection expressions in the Series.Values property, for example: Values = new double[] { 2, 5, 4 } changes to Values = [2, 5, 4]
Changed csharp_style_expression_bodied_methods from `false` to `when_on_single_line:warning` to prefer single-line expression-bodied methods. All other settings remain unchanged.
A lot of changes in this commit, the idea is to simplify all the samples exposed in the web site, it abuses of collection expressions, and removes MVVM ObservableObject when not necessary.
Added a tip section to the documentation to help users troubleshoot issues where the chart might not be showing. The tip suggests that the layout might be hiding the control and recommends explicitly setting the size of the control (Width and Height). It also references related issues #1483 and #1581 for further assistance.
- Streamlined MVVM explanation and added resources in `CommunityToolkit.Mvvm` docs. - Added new sections in `template.md` for title, image, and `ObservablePoint` usage. - Updated `genericSampleHeader.md` and `genericSampleJustGifHeader.md` to mention C# 12 and `CommunityToolkit.Mvvm`. - Updated `genericSampleSimpleHeader.md` to include C# 12 features and a link to the toolkit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.