feat: add global toggle for GPU rendering. closes #1645 #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added support for WPF and Xamarin, and I've hooked the existing Blazor support to the new setting. |
I agree, this is now ready to go into dev. |
beto-rodriguez
previously approved these changes
Nov 5, 2024
Merged
|
I merged this for now, but I'll add a couple of improvements on #1692 Thanks for the PR! |
|
Sounds good :) Thanks for the merge! |
beto-rodriguez
added a commit
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a global toggle to enable/disable GPU rendering, i.e. switching from SKCanvasView to SKGLView. This is primarily useful on Android where canvas rendering can be slow. Closes #1645.
In draft as this is currently just a prototype for the MAUI view, needs to be extended out to the others, but I figured I'd send this to get some feedback.Figured it would be easier to branch off
devfor this rather than continuing fromhardware-accelerated, but happy to move these changes over to there if that's better.