No nullable dp #1746
Merged
No nullable dp #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
beto-rodriguez
commented
Dec 27, 2024
beto-rodriguez
commented
- fixes Chart not rendered if i set "LegendTextSize" with Library ver. >= 2.0.0-rc3 (MAUI) #1694
- fixes While setting properties MinStep and ForceStepToMin, CartesianChart not appearing #1691
Changed LegendTextSize and TooltipTextSize properties in LiveChartsSettings and IChartView from nullable doubles to non-nullable doubles with default values. Updated WithLegendTextSize and WithTooltipTextSize methods to accept non-nullable double parameters.
Modified LegendTextSize and TooltipTextSize properties in SKCartesianChart, SKPieChart, SKPolarChart, SKDefaultLegend, and SKDefaultTooltip from nullable double? to non-nullable double. Removed null checks and default value assignments in SKDefaultLegend and SKDefaultTooltip as these properties are now guaranteed to have a value.
Updated TooltipTextSizeProperty and LegendTextSizeProperty in CartesianChart, PieChart, and PolarChart classes from double? to double. Modified getters to return default values from LiveCharts.DefaultSettings when necessary. Updated Avalonia property registrations accordingly.
Changed the types of _legendTextSize and _tooltipTextSize fields and properties in the Chart class from double? to double. This ensures these fields and properties cannot hold null values, simplifying their handling and avoiding potential null reference issues.
Modified LegendTextSize and TooltipTextSize properties in Chart.cs from nullable double (double?) to non-nullable double (double). Updated DependencyProperty.Register calls and property definitions to reflect this change, ensuring type consistency and avoiding potential null value issues.
Changed LegendTextSize and TooltipTextSize in Chart class from nullable double to non-nullable double. This ensures these properties always have a value, preventing null reference issues. Default values are set to LiveCharts.DefaultSettings.
Modified _legendTextSize and _tooltipTextSize fields and properties in the Chart class from double? to double. This ensures these fields and properties always hold a valid double value, eliminating the possibility of null values.
Updated LegendTextSizeProperty and TooltipTextSizeProperty in CartesianChart, PieChart, and PolarChart to use double instead of object. Changed LegendTextSize and TooltipTextSize properties from nullable double? to non-nullable double. Getters now return default values from LiveCharts.DefaultSettings if null. Ensures type safety and default values for text size properties.
Updated LegendTextSize and TooltipTextSize properties in CartesianChart, PieChart, and PolarChart classes. Changed DependencyProperty registration type from object to double. Removed nullable type for these properties, now using non-nullable double. Added fallback to default settings if values are not set, ensuring consistent type and default values.
Updated LegendTextSize and TooltipTextSize properties in CartesianChart, PieChart, and PolarChart classes to use non-nullable double. Modified DependencyProperty registration for LegendTextSizeProperty and TooltipTextSizeProperty to change type from object to double. Getters now return default values from LiveCharts.DefaultSettings if property values are null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.