Prevent setting MotionCanvas.Sync to null. #811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking #785 I mentioned that you can set
MotionCanvas.Sync
to null in a variety of ways. Originally app crashed because of unhandled exception on thread pool thread which was fixed by PR #776. However in this comment I posted another way to crash the app. There is probably a way to achieve same result using all WPF guidelines, instead of settingDataContext
tonull
explicitly.Simple solution would be to prevent setting this to
null
since it used a lot internally.Stacktrace of crash: