Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some legend rendering issues. #821

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

pkindruk
Copy link
Contributor

Issues fixed:

  • When legend is shown(left) and hidden there was a big empty space. (Canvas.StartPoint was not reset)
  • If legend was hidden initially, then left/right legends had horizontal layout (null-coalescing operator prevented changes to StackPanel)
  • Series.IsVisibleAtLegend was completely ignored. Should probably fix Series visibility in chart legend not working as intended #794.

Copy link
Owner

@beto-rodriguez beto-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@beto-rodriguez
Copy link
Owner

This PR fixes the legend position when it changes, but notice it does not fix #794, I am into that.

@beto-rodriguez beto-rodriguez merged commit bd04814 into beto-rodriguez:master Dec 18, 2022
@pkindruk
Copy link
Contributor Author

pkindruk commented Dec 19, 2022

Yeah, it didn't work for that issue, it was just a blind guess. I had not enough spare time to install WinUI workloads or put together a WPF repro. I fixed my own issue that series created with IsVisibleAtLegend = false were shown in legend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series visibility in chart legend not working as intended
2 participants