-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent use of tracing and bevy_log #11298
Comments
I'm generally for moving this all our tracing usage to bevy_utils, since bevy_log focuses on actually setting up the LogPlugin and the outward facing IO for tracing. This way compilation shouldn't be blocking on compiling bevy_log's extra features when most other crates are really only there to add log messages and instrumentation. |
an issue I have with using bevy_utils for logs is that it exposes |
# Objective Fixes #11298. Make the use of bevy_log vs bevy_utils::tracing more consistent. ## Solution Replace all uses of bevy_log's logging macros with the reexport from bevy_utils. Remove bevy_log as a dependency where it's no longer needed anymore. Ideally we should just be using tracing directly, but given that all of these crates are already using bevy_utils, this likely isn't that great of a loss right now.
# Objective Fixes bevyengine#11298. Make the use of bevy_log vs bevy_utils::tracing more consistent. ## Solution Replace all uses of bevy_log's logging macros with the reexport from bevy_utils. Remove bevy_log as a dependency where it's no longer needed anymore. Ideally we should just be using tracing directly, but given that all of these crates are already using bevy_utils, this likely isn't that great of a loss right now.
Bevy seems to inconsistently switch between using
bevy_utils::tracing
andbevy_log
. It would be good to pick one and use it consistently throughout the project.The text was updated successfully, but these errors were encountered: