Do not emit execution id label by default in single binary (flyteorg#…

…5704) * Do not emit execution id label by default in single binary Signed-off-by: Eduardo Apolinario <[email protected]> * Update flytestdlib/contextutils/context.go Co-authored-by: Thomas J. Fan <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
bgedik · Sep 12, 2024 · 34efd0b · 34efd0b
1 parent add4e48
commit 34efd0b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/cmd/single/start.go b/cmd/single/start.go
@@ -249,6 +249,6 @@ func init() {
 	RootCmd.AddCommand(startCmd)
 	// Set Keys
 	labeled.SetMetricKeys(contextutils.AppNameKey, contextutils.ProjectKey, contextutils.DomainKey,
-		contextutils.ExecIDKey, contextutils.WorkflowIDKey, contextutils.NodeIDKey, contextutils.TaskIDKey,
+		contextutils.WorkflowIDKey, contextutils.NodeIDKey, contextutils.TaskIDKey,
 		contextutils.TaskTypeKey, common.RuntimeTypeKey, common.RuntimeVersionKey, storage.FailureTypeLabel)
 }
diff --git a/flytestdlib/contextutils/context.go b/flytestdlib/contextutils/context.go
@@ -12,14 +12,15 @@ import (
 type Key string
 
 const (
-	AppNameKey         Key = "app_name"
-	NamespaceKey       Key = "ns"
-	TaskTypeKey        Key = "tasktype"
-	ProjectKey         Key = "project"
-	DomainKey          Key = "domain"
-	WorkflowIDKey      Key = "wf"
-	NodeIDKey          Key = "node"
-	TaskIDKey          Key = "task"
+	AppNameKey    Key = "app_name"
+	NamespaceKey  Key = "ns"
+	TaskTypeKey   Key = "tasktype"
+	ProjectKey    Key = "project"
+	DomainKey     Key = "domain"
+	WorkflowIDKey Key = "wf"
+	NodeIDKey     Key = "node"
+	TaskIDKey     Key = "task"
+	// Adding the ExecIDKey label to a metric will cause higher cardinality. Use with caution.
 	ExecIDKey          Key = "exec_id"
 	JobIDKey           Key = "job_id"
 	PhaseKey           Key = "phase"