Merge pull request #60 from BenCastricum/deadlock-fix

Revert defer unlock in StayRTR AddVRPs
bgp · Jan 26, 2022 · c4ac625 · c4ac625
2 parents 1bf0956 + 4fef711
commit c4ac625
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/server.go b/lib/server.go
@@ -346,7 +346,6 @@ func (s *Server) SetSerial(serial uint32) {
 
 func (s *Server) AddVRPs(vrps []VRP) {
 	s.vrplock.RLock()
-	defer s.vrplock.RUnlock()
 
 	vrpCurrent := s.vrpCurrent
 
@@ -357,6 +356,7 @@ func (s *Server) AddVRPs(vrps []VRP) {
 		s.log.Debugf("Computed diff: added (%d), removed (%d), unchanged (%d)", len(added), len(removed), len(unchanged))
 	}
 	curDiff := append(added, removed...)
+	s.vrplock.RUnlock()
 
 	s.AddVRPsDiff(curDiff)
 }