Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the AFI dependency for ASPA #105

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Remove the AFI dependency for ASPA #105

merged 2 commits into from
Dec 21, 2023

Conversation

cjeker
Copy link
Contributor

@cjeker cjeker commented Dec 18, 2023

The AFI was removed from the ASPA profile so don't expect it anymore. Now RTR is still using an old idea of ASPA profile so there just duplicate the object once for IPv4 and once for IPv6. At some points SIDROPS may finally fix this but for now this allows to export ASPA objects that follow the rpki-client JSON (which no longer has the AFI in the ASPA table).

I'm not certain about the changes to slurm but I think it should be fine.
With this stayrtr is able to distribute the ASPA records from the default cache file.

@benjojo
Copy link
Collaborator

benjojo commented Dec 18, 2023

We might want to hold merging this until #103 is done, since that is a much more complex PR that might conflict

@benjojo
Copy link
Collaborator

benjojo commented Dec 18, 2023

Also it's currently very up in the air on what draft-spaghetti-sidrops-aspa-slurm has to say about this output.

@cjeker
Copy link
Contributor Author

cjeker commented Dec 19, 2023

I'm happy to rebase this once #103 is merged as long as #103 is merged soon.
Right now the ASPA support in stayrtr is broken since rpki-client changed the JSON format some time ago but this code was never adjusted.
This was all triggered by this bug report openbgpd-portable/openbgpd-portable#71

The AFI was removed from the ASPA profile so don't expect it anymore.
Now RTR is still using an old idea of ASPA profile so there just
duplicate the object once for IPv4 and once for IPv6. At some points
SIDROPS may finally fix this but for now this allows to export ASPA
objects that follow the rpki-client JSON (which no longer has the
AFI in the ASPA table).
@cjeker
Copy link
Contributor Author

cjeker commented Dec 21, 2023

Rebased after merge of #103

@job job merged commit 4dc8601 into bgp:master Dec 21, 2023
3 checks passed
@cjeker cjeker deleted the kill_aspa_afi branch December 21, 2023 10:59
@ties
Copy link
Collaborator

ties commented Dec 21, 2023

@cjeker do you think there is a reasonable way to have a compatibility mode for both routinator's and rpki-client's output? Ideally we would align those of course.

@benjojo
Copy link
Collaborator

benjojo commented Dec 21, 2023

Do you have an example of routinator output on hand?

@job
Copy link
Member

job commented Dec 21, 2023

What’s the point though? R3000 already has a built-in RTR server.

@cjeker
Copy link
Contributor Author

cjeker commented Dec 21, 2023

I would prefer if routinator would follow the JSON structure of rpki-client for ASPA objects.
The old format with the AFI is dead. It makes no sense to try to support it in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants