-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the AFI dependency for ASPA #105
Conversation
We might want to hold merging this until #103 is done, since that is a much more complex PR that might conflict |
Also it's currently very up in the air on what draft-spaghetti-sidrops-aspa-slurm has to say about this output. |
I'm happy to rebase this once #103 is merged as long as #103 is merged soon. |
e8c44a5
to
3827a6e
Compare
The AFI was removed from the ASPA profile so don't expect it anymore. Now RTR is still using an old idea of ASPA profile so there just duplicate the object once for IPv4 and once for IPv6. At some points SIDROPS may finally fix this but for now this allows to export ASPA objects that follow the rpki-client JSON (which no longer has the AFI in the ASPA table).
3827a6e
to
e7fd422
Compare
Rebased after merge of #103 |
@cjeker do you think there is a reasonable way to have a compatibility mode for both routinator's and rpki-client's output? Ideally we would align those of course. |
Do you have an example of routinator output on hand? |
What’s the point though? R3000 already has a built-in RTR server. |
I would prefer if routinator would follow the JSON structure of rpki-client for ASPA objects. |
The AFI was removed from the ASPA profile so don't expect it anymore. Now RTR is still using an old idea of ASPA profile so there just duplicate the object once for IPv4 and once for IPv6. At some points SIDROPS may finally fix this but for now this allows to export ASPA objects that follow the rpki-client JSON (which no longer has the AFI in the ASPA table).
I'm not certain about the changes to slurm but I think it should be fine.
With this stayrtr is able to distribute the ASPA records from the default cache file.