Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str to int #14

Merged
merged 4 commits into from
Jul 30, 2021
Merged

Str to int #14

merged 4 commits into from
Jul 30, 2021

Conversation

job
Copy link
Member

@job job commented Jul 27, 2021

  • Prefer the VRP's ASN to be uint32
  • Add checks whether the VRP's Prefix Length and Max Length make any sense in relationship to the AFI

@job job requested a review from ties July 27, 2021 20:44
@randomthingsandstuff
Copy link
Contributor

Discussed with @job, no objections from my side.

@randomthingsandstuff randomthingsandstuff merged commit 06d51bb into master Jul 30, 2021
@ties
Copy link
Collaborator

ties commented Aug 1, 2021

Quick reply here (busy day/quick reply from mobile, so bound to be incorrect): I think I read there were some issues with routers receiving packers via rtr with a host part that is non-zero.

This pr fixes the 'prefix length invalid, causing a router to have issues' case but it may be good to double check that the parsing does make sure that the host part is zero. I think rejecting the file is likely better then masking the host part to zero.

To follow up on this: I checked the packets sent after a SLURM file changes that containers a prefix where the host part is non-zero. Stayrtr sends the correct prefix if the host-part is non-zero in the json:

...
"prefixAssertions": [
...
      {
        "asn": 65002,
        "prefix": "10.2.6.128/24",
        "maxPrefixLength": 26
      }
    ]
...

Screenshot from 2021-08-01 18-40-32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants