Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with stable and specified go version #94

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

ties
Copy link
Collaborator

@ties ties commented Mar 3, 2023

No description provided.

@ties ties requested a review from benjojo March 3, 2023 13:56
@ties ties force-pushed the go-versions branch 4 times, most recently from 2f38154 to 774f324 Compare March 3, 2023 14:09
@ties
Copy link
Collaborator Author

ties commented Mar 3, 2023

Finally. Those action things are confusing.

My idea was to build with the latest stable version (= probably what 1.19^'/1.<any> resolves to) as well as with the version we specify in go.mod.

Are there any reasons to move to a more recent go version? If we move to 1.18 we could use generics.

@benjojo
Copy link
Collaborator

benjojo commented Mar 3, 2023

If we move to 1.18 we could use generics

Do we need generics?

In general keeping to the lowest version possible (within reason ofc) helps distros build things

@ties
Copy link
Collaborator Author

ties commented Mar 3, 2023

Do we need generics?

Could probably be added in a few places. I did not feel the need yet.

In general keeping to the lowest version possible (within reason ofc) helps distros build things

Definitely. Otherwise I would have updated to $latest for both builds. I'll merge this - I think that building with the latest compiler for warnings/etc is good, while also being sure that it builds with the version mentioned in go.mod.

@ties ties merged commit 54153e9 into bgp:master Mar 3, 2023
@ties ties deleted the go-versions branch March 3, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants