Add wordcloud #1552
Add wordcloud #1552
Conversation
reytakop
changed the title
|
The output file seems to be missing. |
tools/wordcloud/macros.xml
Outdated
| <requirement type="package" version="2.7.0">codecov</requirement> | ||
| <requirement type="package" version="7.3.2">coverage</requirement> | ||
| <requirement type="package" version="3.8.0">flake8</requirement> | ||
| <requirement type="package" version="7.4.3">pytest</requirement> | ||
| <requirement type="package" version="4.1.0">pytest-cov</requirement> | ||
| <requirement type="package" version="0.9.7">pytest-sugar</requirement> | ||
| <requirement type="package" version="28.0.0">setuptools</requirement> | ||
| <requirement type="package" version="4.0.2">twine</requirement> | ||
| <requirement type="package" version="0.38.1">wheel</requirement> | ||
| <requirement type="package" version="1.5.1">numpydoc</requirement> | ||
| <requirement type="package" version="2.31.1">imageio</requirement> | ||
| <requirement type="package" version="7.2.3">sphinx</requirement> | ||
| <requirement type="package" version="1.2.2">sphinx_rtd_theme</requirement> | ||
| <requirement type="package" version="0.8.2">sphinx_gallery</requirement> | ||
| <requirement type="package" version="0.4.0">sphinx-argparse</requirement> | ||
| <requirement type="package" version="3.0.1">sphinx-issues</requirement> | ||
| <requirement type="package" version="3.8.0">matplotlib</requirement> | ||
| <requirement type="package" version="6.0.4">multidict</requirement> | ||
| <requirement type="package" version="0.42.1">jieba</requirement> | ||
| <requirement type="package" version="1.11.3">scipy</requirement> | ||
| <requirement type="package" version="2.0.2">python-bidi</requirement> | ||
| <requirement type="package" version="3.0.0">arabic_reshaper</requirement> |
There was a problem hiding this comment.
Why is this all needed? I would assume that only wordcloud as dependency works?
There was a problem hiding this comment.
Why is this all needed? I would assume that only wordcloud as dependency works?
Yes, it works with only Wordclous as a requirement.
tools/wordcloud/wordcloud.xml
Outdated
| <param argument="--random_state" type="integer" label="Random seed"/> | ||
| <param argument="--no_normalize_plurals" value="True" type="boolean" optional="True" label="Whether to remove trailing s from words"/> | ||
| <param argument="--repeat" type="boolean" truevalue="True" falsevalue="False" value="False" label="Whether to repeat words and phrases until max_words or min_font_size is reached"/> | ||
| <param argument="--version" type="boolean" truevalue="True" falsevalue="False" value="False" label="Show program's version number"/> |
There was a problem hiding this comment.
version should not be offered to the user, but you should add a <version_command> tag to the tool.
There was a problem hiding this comment.
version should not be offered to the user, but you should add a
<version_command>tag to the tool.
Thanks, I deleted this line.
|
I see this error here:
|
|
The wordcloud.xml file was updated. |
|
@reytakop It seems that there is a problem in your command section.
|
tools/wordcloud/wordcloud.xml
Outdated
| <validator type="regex" message="Please select a valid RGB color">[#][0-9A-Fa-f]{6}</validator> | ||
| </param> | ||
| <param argument="--mask" type="data" format="png" optional="True" label="Mask to use for the image form"/> | ||
| <param argument="--colormask" type="data" format="png" optional="True" label="Color mask to use for image coloring"/> |
There was a problem hiding this comment.
here are many "color" options, should they be in your color-conditional?
tools/wordcloud/wordcloud.xml
Outdated
| --max_font_size $max_font_size | ||
| --font_step $font_step | ||
| --margin $margin | ||
| --color $color |
There was a problem hiding this comment.
This parameter is inside a conditional. You need to have an if-condition here that models your conditional I think.
|
The wordcloud.xml file was updated, and the related error was fixed. |
tools/wordcloud/macros.xml
Outdated
| @@ -0,0 +1,8 @@ | |||
| <macros> | |||
| <token name="@TOOL_VERSION@">1.9.4</token> | |||
There was a problem hiding this comment.
If its just one tool, you can move this into the tool if you like - not as a separate file.
There was a problem hiding this comment.
If its just one tool, you can move this into the tool if you like - not as a separate file.
Thanks for your comment. The files were updated based on your suggestion.
There was a problem hiding this comment.
Ah, you misunderstood: using the tokens instead of hard-coded versions is important for automated update suggestions, but you can set the macros right in the tool xml instead of expanding them from another file.
There was a problem hiding this comment.
Ah, you misunderstood: using the tokens instead of hard-coded versions is important for automated update suggestions, but you can set the macros right in the tool xml instead of expanding them from another file.
Thanks for your comment. I updated the file.
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
The wordcloud.xml, macros.xml, and.shed.yml files were added.