-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest new features #32
Comments
Hi more data that can be added can include google maps links for the countries , and for currency how much is worth 1 dollar or something like that , and gdp per capita can also be an important information that can be added. |
Great ideas! |
I think area and population are basic and useful stats. Adding these would be very useful. |
Sounds good @amanpalariya |
In #23, you have mentioned that population is variable and therefore should not be added. If no one is working on 'adding area', I would like to take up this task. 😃 |
@amanpalariya okay thanks for reminding me 😀, sure you can pick it up. Should I assign you to it? |
@bhatvikrant Sure. I'd like to work on it. |
Hello everyone 👋,
So after adding those things, each {
"country": "poland",
"capital": "warsaw",
"currency": "zloty",
"native_language": ["polish"],
"famous_for": "pierogi and potatoes",
"phone_code": "+48",
"flag": "https://flagpedia.net/data/flags/h80/pl.png",
"drive_direction": "right",
// NEW DATA
"continent": "europe", // 1
"iso": { // 2
"numeric": 616,
"alpha2": "PL",
"alpha3": "POL"
},
"ccTLD": ".pl", // 3
"area": { // 4
"size": 312685,
"unit": "km2"
}
}, Together with that I can create extra methods:
I can prepare all of this pretty easy (I have all this data in non-js/non-json format) so please let me know if I can deliver this. PS: We can create a separate issue for this, so #32 issue can be assigned to @amanpalariya and I can have separate one assigned to me |
@sthiepaan great suggestions buddy. I think this will be interesting data for the library, so let's do this. @amanpalariya and @sthiepaan please create separate issues for your respective tasks and I will assign them to you 😀. PS. Please don't forget to update the README.md file and test cases. (or else create a separate issue mentioning whatever is left by you, so that some other contributor can pick it up.) cheers. |
Hello Guys, 👋 Few features i would like to propose, -> Let's highlight the word searched by the user in the results section, it can be either by giving it a background or making it bold. -> I know Population is variable, but what if we can add a Slider or let's say ask user to enter a range from which he can select. If a user wants to know countries having population of over a billion or less, this will be helpful.🧐 . -> Also lets restructure the data in famous_for field, currently we are separating it with and, lets do it something like below Lets categorize it so that when the data grows it will be easier to maintain, I will be happy to do that. 😃 In order to implement this we can add a dropdown with the searchbar listing these categories, user can select one of them and search. -> Lets implement Advanced Search feature to narrow down results for the user, currently if you search for english speaking countries there are more than 20 odd results. Let's move some of the features like famous for, capital, currency in advanced search section. The point being, allow user more than one option to search with. 😓 Let me know guys, would love to implement some of these features. I am new to open source collab, eager to learn. PS: I was also thinking of allowing user to fetch results even if they enter wrong spelling, lets say englsh instead of English. We can implement to ignore.. .............ok may be someother time 😅 |
Hello @jav7zaid 👋,
This project has nothing to do with that since it is an API that delivers data. It is on the package user side to prepare frontend functionalities. We should focus on populating the data and deliver methods that allow API consumers to have more possibilities to grab it.
Partly same as previous one but actually we have in plans to add
I had similar idea where we can define (and deliver) some categories for that section of API. It could be similar to {
// ...,
"famous_for": {
"food": ["pierogi", "potatoes"],
"sport": ["ski jumping", "volleyball"],
// ...
},
...
} and then refacator
Not a part of this package - we leave UI part for users of this project/package 😉 But we could create a method to let users get property names so they can build that. Not 100% sure how we could prepare this in a clean and proper way tho.
That is another topic I was thinking of. But not in terms of UI (this is left for the users) but from the API perspective. What you call "advanced search", from API point of view we can call "chaining queries". Currently it is not possible at all since all methods are using initial data. This could be changed by having additional methods.
I am not sure if this should be handled by API. For me it sounds like some kind of data mapping that should be handled by API consumers. That kind of feature require additional resources for searching (and "guessing" what user meant) so for me it is package users decision if they need any kind of precision thingy. Thank you for all your input @jav7zaid! What do you think @bhatvikrant @amanpalariya? |
Great suggestions @jav7zaid! Sounds good @sthiepaan, I agree with your points. |
@sthiepaan @bhatvikrant thanks for the review, i agree with respect to UI part to be handled by consumer. @bhatvikrant let me know if can open a separate issue for getting countries within a range of Area/Population as input or any of the features you feel can be worked upon. As suggested by @sthiepaan, we could have seperate methods getCountriesByAreaRange(from, to) for Area Looking forward to contribute. |
For Regarding |
I created a few issues related to our discussion so far. Feel free to grab some if interested 😉. I also have another ideas of properties we could add. Let me write it in an ordered list so we can refer to them easily 😉
Of course, each of these properties will require us to create an additional methods to consume that data. |
Yes, I think we should leave out population for now at least since it is quite variable. |
Greate Job @sthiepaan thanks for these awesome points! Lets get this bread 🍞 |
Great! I will create separate issues for that, so we can discuss that in more details (if necessary) |
Okay! Yes, we can discuss before implementing 😁 |
Hi, |
No description provided.
The text was updated successfully, but these errors were encountered: