issue SeleniumHQ#1571: correct initialization of custom node

modified: customize_node.en.md modified: customize_node.ja.md modified: customize_node.pt-br.md modified: customize_node.zh-cn.md
bhecquet · Feb 6, 2024 · 4636a53 · 4636a53
1 parent f9d840c
commit 4636a53
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 12 deletions.
diff --git a/website_and_docs/content/documentation/grid/advanced_features/customize_node.en.md b/website_and_docs/content/documentation/grid/advanced_features/customize_node.en.md
@@ -95,8 +95,8 @@ public class DecoratedLoggingNode extends Node {
 
   private Node node;
 
-  protected DecoratedLoggingNode(Tracer tracer, URI uri, Secret registrationSecret) {
-    super(tracer, new NodeId(UUID.randomUUID()), uri, registrationSecret);
+  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret) {
+	super(tracer, nodeId, uri, registrationSecret);
   }
 
   public static Node create(Config config) {
@@ -109,7 +109,9 @@ public class DecoratedLoggingNode extends Node {
     Node node = LocalNodeFactory.create(config);
 
     DecoratedLoggingNode wrapper = new DecoratedLoggingNode(loggingOptions.getTracer(),
-        uri, secretOptions.getRegistrationSecret());
+				node.getId(),
+				uri,
+				secretOptions.getRegistrationSecret());
     wrapper.node = node;
     return wrapper;
   }

diff --git a/website_and_docs/content/documentation/grid/advanced_features/customize_node.ja.md b/website_and_docs/content/documentation/grid/advanced_features/customize_node.ja.md
@@ -100,8 +100,8 @@ public class DecoratedLoggingNode extends Node {
 
   private Node node;
 
-  protected DecoratedLoggingNode(Tracer tracer, URI uri, Secret registrationSecret) {
-    super(tracer, new NodeId(UUID.randomUUID()), uri, registrationSecret);
+  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret) {
+	super(tracer, nodeId, uri, registrationSecret);
   }
 
   public static Node create(Config config) {
@@ -114,7 +114,9 @@ public class DecoratedLoggingNode extends Node {
     Node node = LocalNodeFactory.create(config);
 
     DecoratedLoggingNode wrapper = new DecoratedLoggingNode(loggingOptions.getTracer(),
-        uri, secretOptions.getRegistrationSecret());
+				node.getId(),
+				uri,
+				secretOptions.getRegistrationSecret());
     wrapper.node = node;
     return wrapper;
   }

diff --git a/...e_and_docs/content/documentation/grid/advanced_features/customize_node.pt-br.md b/...e_and_docs/content/documentation/grid/advanced_features/customize_node.pt-br.md
@@ -90,8 +90,8 @@ public class DecoratedLoggingNode extends Node {
 
   private Node node;
 
-  protected DecoratedLoggingNode(Tracer tracer, URI uri, Secret registrationSecret) {
-    super(tracer, new NodeId(UUID.randomUUID()), uri, registrationSecret);
+  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret) {
+	super(tracer, nodeId, uri, registrationSecret);
   }
 
   public static Node create(Config config) {
@@ -104,7 +104,9 @@ public class DecoratedLoggingNode extends Node {
     Node node = LocalNodeFactory.create(config);
 
     DecoratedLoggingNode wrapper = new DecoratedLoggingNode(loggingOptions.getTracer(),
-        uri, secretOptions.getRegistrationSecret());
+				node.getId(),
+				uri,
+				secretOptions.getRegistrationSecret());
     wrapper.node = node;
     return wrapper;
   }

diff --git a/...e_and_docs/content/documentation/grid/advanced_features/customize_node.zh-cn.md b/...e_and_docs/content/documentation/grid/advanced_features/customize_node.zh-cn.md
@@ -100,8 +100,8 @@ public class DecoratedLoggingNode extends Node {
 
   private Node node;
 
-  protected DecoratedLoggingNode(Tracer tracer, URI uri, Secret registrationSecret) {
-    super(tracer, new NodeId(UUID.randomUUID()), uri, registrationSecret);
+  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret) {
+	super(tracer, nodeId, uri, registrationSecret);
   }
 
   public static Node create(Config config) {
@@ -114,7 +114,9 @@ public class DecoratedLoggingNode extends Node {
     Node node = LocalNodeFactory.create(config);
 
     DecoratedLoggingNode wrapper = new DecoratedLoggingNode(loggingOptions.getTracer(),
-        uri, secretOptions.getRegistrationSecret());
+				node.getId(),
+				uri,
+				secretOptions.getRegistrationSecret());
     wrapper.node = node;
     return wrapper;
   }