Add a colored output on Windows?

[alekseysidorov]

At the moment criterion output on windows doesn't support colors, thus it is harder to understand benchmark results that on *nix.

[bheisler]

Hey, thanks for the suggestion! That seems like a reasonable feature to add, but I don't typically develop on Windows. Pull requests would be welcome, though!

[vpetrigo]

Hey @alekseysidorov,

Would you please specify which Windows version you mean? I'm on Windows 10 (build 1809 - 10.0.17763) and color output works fine for me.

So that's is the short snippet I added into the report.rs:

    #[test]
    fn test_windows_colors() {
        let cli = CliReport::new(false, true, false);
        let hello = "Hello";

        println!("{}", cli.green(hello.to_string()));
        println!("{}", cli.red(hello.to_string()));
    }

And how it looks in the plain cmd:

That's how the benchmarks output of criterion.rs itself looks like in my cmd:

I may elaborate on that, but need more info about the system you experienced such an issue. 😄

[vpetrigo]

Small update on that: seems like that issue with lack of colors in Windows terminals has been fixed in rust-lang/cargo#4722. So I was able to reproduce OP's issue with Rust 1.26.0, but it went away after I switched back to the stable-msvc toolchain.

[alekseysidorov]

I am using rustc version 1.32.0 and powershell as shell. Sometimes I run tests in git-bash but I never tried to run criterion benchmarks in cmd.exe.

[vpetrigo]

@alekseysidorov try to run you benchmarks with the following command: cargo bench -- --color=always. I guess there are some issues with traking PowerShell color output features.

[alekseysidorov]

With additional argument works fine in powershell

But without them colors do not work:
cmd.exe

powershell

[vpetrigo]

Would you specify which OS version you use and Criterion.rc?

[vpetrigo]

@alekseysidorov @bheisler I found potential fix, so will work on a PR.

[alekseysidorov]

Sorry for delay ^_^, my OS is Windows 10 release 1809 (17763.316)

[alekseysidorov]

And I used a master branch of criterion-rs.

[bheisler]

Hey, thanks for the patience - I've been on vacation for a week and a half or so.

This fix looks good to me. @alekseysidorov Does this solve the issue for you?

[bheisler]

Closing this; it seems to be fixed.