Enable proper text coloring on Windows #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Then this looks good to me. Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR addresses #267. According to rust-lang/cargo#4722 the misbehaving of color output with
rustcandcargohas been fixed. Alsoattyis able to properly determine whether we use TTY on Windows or not. That small fix correctly enables color ouput while using Windowscmdandpowershellutilities and also does not break down compatibility with Unix terminal programs.I'd like to ask @alekseysidorov to validate whether that fix properly works on his machine. My test configuration was the following:
build 1809 - 10.0.17763)rust 1.32.0rust 1.33.0