Merge pull request #114 from bigbitecreative/feature/shellcheck

Add shellcheck to linter list
bigbite · Jan 21, 2019 · e3a0dc0 · e3a0dc0
2 parents 22fb3f6 + c69822a
commit e3a0dc0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/bin/version-bump.sh b/bin/version-bump.sh
@@ -1,6 +1,6 @@
 #!/usr/bin/env sh
 
-# ./bin/bump.sh [<version>]
+# ./bin/version-bump.sh [<version>]
 #   <version> The version release version to increment.
 #     default: patch
 #     options: major|minor|patch
@@ -10,11 +10,11 @@
 # - /includes/scripts-and-styles.php
 #
 # EXAMPLE USAGE:
-#   ./bin/bump.sh minor
+#   ./bin/version-bump.sh minor
 
 # escape a version number for sed
 _v() {
-    echo "$(echo "$1" | tr -d '\n' | sed 's/\./\\\./g')";
+    echo "$1" | tr -d '\n' | sed 's/\./\\\./g';
 }
 
 # cross-compatible sed in-place

diff --git a/package.json b/package.json
@@ -82,10 +82,11 @@
     "webpack": "^3.6.0"
   },
   "scripts": {
-    "lint": "yarn lint-scripts && yarn lint-styles && yarn lint-php",
+    "lint": "yarn lint-scripts && yarn lint-styles && yarn lint-php && yarn lint-shell",
     "lint-php": "$(composer config -g home)/vendor/bin/phpcs .",
     "lint-scripts": "./node_modules/.bin/eslint ./src/",
     "lint-styles": "./node_modules/.bin/stylelint \"src/**/*.scss\"",
+    "lint-shell": "type shellcheck > /dev/null 2>&1 && shellcheck ./bin/*.sh",
     "test": "./node_modules/.bin/jest",
     "build": "export \"${NODE_ENV:-production}\"; gulp --production",
     "watch": "export \"${NODE_ENV:-production}\"; gulp watch --production",