Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Theme Check requirements #27

Merged
merged 22 commits into from
Dec 10, 2018
Merged

Theme Check requirements #27

merged 22 commits into from
Dec 10, 2018

Conversation

jaymcp
Copy link
Member

@jaymcp jaymcp commented Dec 10, 2018

Fixes #21, #24

Proposed Changes

This PR implements several fixes, tweaks, and features to resolve the majority of issues reported by the Theme Check plugin for compatibility with WP.org themes.

Fixes

  • Screenshot is now at the recommended dimensions
  • An unused variable has been removed
  • Theme URI in style.css has been corrected
  • Tags have been added to style.css
  • Invalid i18n textdomain has been corrected x1
  • An unused function has been removed

Tweaks

  • Theme options are now in the recommended Appearance menu
  • <title> tag output is now handled by WP
    • to disable blogname appending to title, return false in filter benenson_append_blogname_to_wp_title
  • Favicons now handled by WP's Site Icon setting in Customizer
  • Asset paths/URIs (& associated build tasks) have been moved to the theme root dir
  • Several required CSS classes have been declared

Features

  • Support for comments (behind a new filter: benenson_comments_enabled)
  • Support for display of article author on single (behind a new filter: benenson_display_author)
  • Basic support for paginated posts/pages
  • Basic support for tags
    • tags will now render on single, if added
      • tag class name can be modified using a new filter: benenson_post_tag_classname

@ampersarnie
Copy link
Member

ampersarnie commented Dec 10, 2018

This is awesome, loads of needed changes here, should put us on perfect footing to focus on features, etc. Nice work.

Copy link
Contributor

@scottblackburn scottblackburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this @jonmcp

@ampersarnie ampersarnie merged commit fded44d into develop Dec 10, 2018
@jaymcp jaymcp deleted the feature/wporg branch December 10, 2018 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants