This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is easily managed using the 'Site Icon' setting in Customizer
NB: will require a wiki update - adds a new filter for toggling author display: 'benenson_display_author'
This is awesome, loads of needed changes here, should put us on perfect footing to focus on features, etc. Nice work. |
ampersarnie
approved these changes
Dec 10, 2018
scottblackburn
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this @jonmcp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21, #24
Proposed Changes
This PR implements several fixes, tweaks, and features to resolve the majority of issues reported by the Theme Check plugin for compatibility with WP.org themes.
Fixes
Tweaks
<title>
tag output is now handled by WPbenenson_append_blogname_to_wp_title
Features
benenson_comments_enabled
)benenson_display_author
)benenson_post_tag_classname