Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Feature/section bg image #50

Merged
merged 5 commits into from
Jan 9, 2019
Merged

Feature/section bg image #50

merged 5 commits into from
Jan 9, 2019

Conversation

con322
Copy link
Contributor

@con322 con322 commented Jan 7, 2019

Proposed Changes

  • Ability to add background image to a section block

@scottblackburn scottblackburn requested a review from jaymcp January 8, 2019 12:21
jaymcp
jaymcp suggested changes Jan 8, 2019
View reviewed changes
Copy link
Member

@jaymcp jaymcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new localised string has been added, but the language files have not been updated.
Run yarn lang to rebuild the string indices, and then update, pre-translate, and save the POT & PO files using Poedit.

@con322 con322 merged commit 618a084 into develop Jan 9, 2019
@jaymcp jaymcp deleted the feature/section-bg-image branch January 11, 2019 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ampersarnie ampersarnie ampersarnie left review comments

@jaymcp jaymcp jaymcp approved these changes

@scottblackburn scottblackburn Awaiting requested review from scottblackburn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@con322 @jaymcp @ampersarnie