Topology sorting functionality added with docs #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
========================================
- Coverage 82.7% 78.9% -3.8%
========================================
Files 11 12 +1
Lines 266 275 +9
========================================
- Hits 220 217 -3
- Misses 46 58 +12
Continue to review full report at Codecov.
|
|
Ok I see, I have to create a test for this. |
|
|
||
| .. code-block:: js | ||
|
|
||
| let bdb = new driver.Connection('https://test.ipdb.io/api/v1/', { | ||
| let bdb = new driver.Connection('https://test.bigchaindb.com/api/v1/', { | ||
| app_id: 'dgi829l9', | ||
| app_key: 'u008ik1bf83b43ce3a95uu0727e66fb9' | ||
| }) |
There was a problem hiding this comment.
I guess those credentials were valid for IPDB, not for the BigchainDB Test Network anymore. Maybe they could be avoided with
{
app_id: "Get one from testnet.bigchaindb.com",
app_key: "Get one from testnet.bigchaindb.com"
}
|
Also, are you planning to add some tests for the |
| @@ -35,12 +35,14 @@ A simple connection with BigchainDB can be established like this. | |||
|
|
|||
| const conn = new driver.Connection(API_PATH) | |||
|
|
|||
| It is also possible to connect to a BigchainDB node of the IPDB test net. | |||
| To do so, you need to pass the **app_id and app_key**. | |||
| Previously you could connect to IPDB testnet, but it has been shutdown. | |||
There was a problem hiding this comment.
We don't need to explain about IPDB history. I would say that we are connection to BigchainDB node.
jernejpregelj
suggested changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.