Fix ByteArray warning, declare compatibility with GNOME Shell 42 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft until I test it with older and newer GNOME Shell versions. |
|
Confirmed to work with GNOME Shell 3.38.6 (Debian 11), 41.4 (Debian testing) and 42.0 (Debian unstable). |
Previously, this logged a warning:
Some code called array.toString() on a Uint8Array instance.
Previously this would have interpreted the bytes of the array
as a string, but that is nonstandard. In the future this will
return the bytes as comma-separated digits. For the time being,
the old behavior has been preserved, but please fix your code
anyway to explicitly call ByteArray.toString(array).
The byteArray module mentioned in the warning is itself non-standard,
and in gjs >= 1.70, there is a standard JavaScript replacement for it,
the TextEncoder object. For details see
<https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1946>.
Signed-off-by: Simon McVittie <[email protected]>
Resolves: biji#14
Signed-off-by: Simon McVittie <[email protected]> Bug-Debian: https://bugs.debian.org/1008535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extension: Avoid deprecated conversion from Uint8Array to String
Previously, this logged a warning:
The byteArray module mentioned in the warning is itself non-standard,
and in gjs >= 1.70, there is a standard JavaScript replacement for it,
the TextEncoder object. For details see
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1946.
Resolves: relies on deprecated Uint8Array.toString conversion #14
metadata: Declare compatibility with GNOME Shell 42
Bug-Debian: https://bugs.debian.org/1008535