Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to GNOME Shell 45 #22

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Port to GNOME Shell 45 #22

merged 2 commits into from
Oct 16, 2023

Conversation

Totto16
Copy link
Contributor

@Totto16 Totto16 commented Oct 15, 2023

This ports the extension to GNOME Shell 45

It comes with some structural changes:

  • The imports are handled differently
  • The export has to be a class, so everything is now encapsulated in a class
  • The backwards compatibility was removed, since it's not possible to support that anymore (as enforced by the new import and export modes, see here )

For some porting references, see here

I suggest creating a new branch for the legacy version of the app, and create a separate one / use the master branch for any GNOME Shell >= 45 development and versions

This was tested on my Machine with GNOME Shell 45.0 and everything works

- refactor everything into class , since the required export format is now a class!
- only compatible with gome shell >= 45
@biji
Copy link
Owner

biji commented Oct 16, 2023

Thanks for the patch and suggestion
Tested on fedora 39 beta and looks good

legacy branch named legacy-44

@biji biji merged commit d79177e into biji:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants