Refactor timeout handling for GNOME 45 compatibility #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biji
reviewed
Nov 20, 2023
| this.timeout = Mainloop.timeout_add_seconds(this.refreshTime, this.parseStat.bind(this)); | ||
| this.timeout = GLib.timeout_add( | ||
| GLib.PRIORITY_DEFAULT, | ||
| this.refreshTime, |
There was a problem hiding this comment.
The multiplication by 200 was implemented to adjust the update interval, aiming to improve user experience. Originally, the update timing was set in such a way that the read or write values were updated too quickly, leading to unstable and sometimes uncomfortable viewing for the user.
These values often appeared and disappeared almost instantaneously, making it difficult to read and interpret the data in real-time. By adjusting the update interval to a slightly longer period (by multiplying by 200), we achieved an update rate that allows for a more stable and understandable display of values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the timeout mechanism from Mainloop.timeout_add_seconds to GLib.timeout_add to ensure compatibility with GNOME 45. The refresh time is now multiplied by 200 to convert it into milliseconds, aligning with GLib.timeout_add's requirements for precise timing.