Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward Non-compabile changes between 2.0.0-beta.3 and 2.0.0-rc3 #724

Closed
haochenuw opened this issue Oct 3, 2024 · 5 comments
Closed

Comments

@haochenuw
Copy link

It seems between these releases the following

pub struct WriteFixedArrayLength {}

was removed. This is a breaking change since clients could be using the struct in their code. Could this be fixed?

@VictorKoenders
Copy link
Contributor

Relevant PR: #625
The entire array implementation was not compatible with bincode 1, so we ripped it out and fixed that issue.

That PR ends with:

They may be re-added in the future.

So I think this option is still open

@VictorKoenders
Copy link
Contributor

One question I have is why you would want to care if bincode writes array lengths or not. What is your use case?

@haochenuw
Copy link
Author

haochenuw commented Oct 4, 2024 via email

@VictorKoenders
Copy link
Contributor

If the user shouldn't care, why was this struct exposed to the public?

That's why we removed it 😄

@ZoeyR
Copy link
Collaborator

ZoeyR commented Oct 4, 2024

Backwards compatibility is not something we guarantee before the final stable release of 2.0. If absolute stability is necessary the 1.0 branch should be used instead.

@ZoeyR ZoeyR closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants