Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bincode 1 compatibility framework #489

Merged
merged 7 commits into from
Feb 1, 2022
Merged

Bincode 1 compatibility framework #489

merged 7 commits into from
Feb 1, 2022

Conversation

VictorKoenders
Copy link
Contributor

@VictorKoenders VictorKoenders commented Jan 23, 2022 •
edited
Loading

Closes #450

@VictorKoenders VictorKoenders force-pushed the bincode_1_compatibility branch from ece030e to 077fc7f Compare January 23, 2022 10:44
@codecov
Copy link

codecov bot commented Jan 23, 2022 •
edited
Loading

Codecov Report

Merging #489 (23df719) into trunk (4d12ecc) will increase coverage by 0.01%.
The diff coverage is 66.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #489      +/-   ##
==========================================
+ Coverage   68.33%   68.35%   +0.01%     
==========================================
  Files          40       43       +3     
  Lines        2969     3049      +80     
==========================================
+ Hits         2029     2084      +55     
- Misses        940      965      +25
Impacted Files Coverage Δ
compatibility/src/lib.rs 50.90% <50.90%> (ø)
compatibility/src/rand.rs 100.00% <100.00%> (ø)
compatibility/src/sway.rs 100.00% <100.00%> (ø)
src/config.rs 90.47% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d12ecc...23df719. Read the comment docs.

@VictorKoenders VictorKoenders force-pushed the bincode_1_compatibility branch from b98b295 to 3a9de8f Compare February 1, 2022 08:10
@VictorKoenders VictorKoenders changed the title [WIP] Bincode 1 compatibility Bincode 1 compatibility framework Feb 1, 2022
@VictorKoenders VictorKoenders marked this pull request as ready for review February 1, 2022 08:11
@VictorKoenders VictorKoenders requested a review from ZoeyR February 1, 2022 08:13
ZoeyR
ZoeyR reviewed Feb 1, 2022
View reviewed changes
compatibility/src/lib.rs Show resolved Hide resolved
compatibility/src/lib.rs Show resolved Hide resolved
compatibility/src/rand.rs Show resolved Hide resolved
@VictorKoenders VictorKoenders merged commit 9d70b8c into trunk Feb 1, 2022
@VictorKoenders VictorKoenders deleted the bincode_1_compatibility branch February 1, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZoeyR ZoeyR ZoeyR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate that bincode 1 and 2 produce the exact same output
2 participants
@VictorKoenders @ZoeyR