Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross platform tests #540

Merged
merged 5 commits into from
May 21, 2022
Merged

Fix cross platform tests #540

merged 5 commits into from
May 21, 2022

Conversation

VictorKoenders
Copy link
Contributor

This PR updates the list of targets being tested to match cross 0.2.1 (the current latest version). Previously the list was based on main, and a lot of the targets simply didn't exist.

Some of the targets are commented out because they simply don't build. Bincode passes all tests on all targets that successfully build.

powerpc64le-unknown-linux-gnu technically builds but fails the test, but this is soley because of a bug in floating points on qemu, where all f32 and f64 values are 0.0 and aren't equal to each other. cross-rs/cross#644

@VictorKoenders VictorKoenders requested a review from ZoeyR April 18, 2022 08:07
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #540 (1e1ff03) into trunk (2d3f420) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##            trunk     #540   +/-   ##
=======================================
  Coverage   69.45%   69.46%           
=======================================
  Files          46       46           
  Lines        3179     3180    +1     
=======================================
+ Hits         2208     2209    +1     
  Misses        971      971           
Impacted Files Coverage Δ
tests/basic_types.rs 99.33% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3f420...1e1ff03. Read the comment docs.

@VictorKoenders VictorKoenders linked an issue Apr 18, 2022 that may be closed by this pull request
19 tasks
@VictorKoenders VictorKoenders merged commit 361d94a into trunk May 21, 2022
@VictorKoenders VictorKoenders deleted the ci/fix_cross_platform_tests branch May 21, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure bincode passes tests on all platforms
2 participants