Add passing bash version to read_vars_file #729
Conversation
|
Thanks for this change! We can make it ready for review since the sh-expand library v0.1.7 is deployed to PyPI! Could you change the bash version to be read only once here (https://github.com/binpash/pash/blob/future/pa.sh)? This script runs in bash so it should be able to determine the version and save it in a variable. This is better than hiding the call to bash deep in the compiler. |
|
OS = |
|
OS:ubuntu-20.04 |
|
Thanks @BolunThompson ! Could you sign the commits for the DCO to pass? Then I will merge the PR :) |
Signed-off-by: Bolun Thompson <[email protected]>
Signed-off-by: Bolun Thompson <[email protected]>
BolunThompson
force-pushed
the
read-env-vars-version
branch
from
6eb1e15 to
4426066
Compare
|
OS = |
|
OS:ubuntu-20.04 |
Use the bash version to determine how to parse the vars file as discussed in binpash/sh-expand#7. Should be merged at the same time as those changes (and will fail any tests until then).