Fix —assert-* checks #742
Merged
Fix —assert-* checks #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, --assert_compiler_success hangs. --assert_all_regions_parallelizable doesn't fail, but I also copied the change there. The tests using the flag pass. Signed-off-by: Bolun Thompson <[email protected]>
Signed-off-by: Bolun Thompson <[email protected]>
|
OS = |
|
OS:ubuntu-20.04 |
This was referenced Jan 11, 2025
|
Great job! |
kwakubiney
pushed a commit
to kwakubiney/pash
that referenced
this pull request
Jan 28, 2025
* Fix: inform_daemon_exit on assertion exit Otherwise, --assert_compiler_success hangs. --assert_all_regions_parallelizable doesn't fail, but I also copied the change there. The tests using the flag pass. Signed-off-by: Bolun Thompson <[email protected]> * Fix: correctly parse "is parallelizable" output Signed-off-by: Bolun Thompson <[email protected]> --------- Signed-off-by: Bolun Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call inform_daemon_exit on —assert_* exit. Otherwise, --assert_compiler_success hangs while pash waits for an exit message that never comes. The tests don’t currently use this flag, but it will be used for Merge changes in to support parsing bash scripts #737.
Corectly parse is_parallelizable output. Doesn’t affect the tests, since --assert_all_regions_parallelizable failed anyways on the non-zero error code.