Allow try to have a custom list of ignored paths #91
Conversation
| while getopts ":yvnD:U:" opt | ||
| # Includes all patterns given using the `-i` flag | ||
| # Each pattern is preceded by an -e so as to be immediately passed to grep. | ||
| IGNORE_FILE=$(mktemp) |
There was a problem hiding this comment.
The cleanup PR is not merged yet, I can help with rebasing the other PR after we merge this (or vice versa) and add it to the cleanup there/then
There was a problem hiding this comment.
Explains why I didn't see it on first glance. 😅
There was a problem hiding this comment.
But actually: that PR isn't going to merge until we understand why overlayfs's workdir is behaving the way it does. These files are tiny and unimportant, but it may pay to merge the cleanup logic for this now.
There was a problem hiding this comment.
Just to be clear, you mean merging the cleanup logic that has to do with our tempfiles here and leaving the SANDBOX_DIR cleanup for the other PR?
If that is what you propose, I suggest to comment out the SANDBOX_DIR cleanup in the other PR, merge it, merge this too after making sure it cleans up the IGNORE_FILE too, and then make a new PR to figure out the SANDBOX_DIR CLEANUP issue (which seems like a bigger issue).
There was a problem hiding this comment.
That all sounds great, but maybe make an issue rather than a PR for the SANDBOX_DIR cleanup? After spending ~1hr debugging in CI, I think we should pull back and figure out what's going on before working on code. Happy to leave it as a draft PR, if you want it to feel more "pending".
No description provided.