report error if qualifiers are wrong in any way #440
Merged
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, filter wrong qualifiers
|
Alas, I trust that this works, but let's add this to the let's-do-after- |
|
@kltm what did we decide on this? Are we chucking everything that doesn't fit then (including spaces) and not repairing like your notes? Sorry I didn't take a look at this yesterday and now our convo has faded. |
|
@dougli1sqrd Going by my notes, it is to be considered an unrecoverable error if something is in that column that does not conform to spec. |
|
Okay. I'll update the implementation then. Once this is merged I can release ontobio, and update go-site. |
dougli1sqrd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, filter wrong qualifiers
For geneontology/helpdesk#252
This fixes a bug where malformed qualifiers and wrong qualifiers not allowed were all allowed through the parser with no issue.
Qualifiers with spaces will be repaired with underscores.