Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 544 rulesets #545

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Issue 544 rulesets #545

merged 5 commits into from
Apr 12, 2021

Conversation

dougli1sqrd
Copy link
Contributor

For #544

@dougli1sqrd dougli1sqrd requested review from dustine32 and kltm April 9, 2021 00:08
@kltm
Copy link
Member

kltm commented Apr 9, 2021

Looks good to me so far.
Is the idea that if you declare rules, but don't specify, they all run, or does one need to be explicit?
I'll leave it to @dustine32 to do final review and merge.

dustine32
dustine32 approved these changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks pretty cool.

@dougli1sqrd
Copy link
Contributor Author

Yeah, in ontobio-parse-assocs if no rules are specified, then none are run. You can pass in the string "all" to set all the rules, otherwise, it just uses whatever set you pass in via repeated -l <N>

@kltm
Copy link
Member

kltm commented Apr 12, 2021

Okay--sounds good. Looks good to me.

@kltm kltm merged commit 7d0d4b1 into master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustine32 dustine32 dustine32 approved these changes

@kltm kltm Awaiting requested review from kltm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougli1sqrd @kltm @dustine32