Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(grit): use to_ascii_lowercase_cow #4053

Merged
merged 1 commit into from
Sep 23, 2024
Merged

perf(grit): use to_ascii_lowercase_cow #4053

merged 1 commit into from
Sep 23, 2024

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 23, 2024

Summary

Replaces a call to to_ascii_lowercase

Test Plan

CI should pass

@github-actions github-actions bot added A-Parser Area: parser L-Grit Language: GritQL labels Sep 23, 2024
@dyc3 dyc3 merged commit 20a726c into main Sep 23, 2024
14 checks passed
@dyc3 dyc3 deleted the 09-23-perf_grit_use_to_ascii_lowercase_cow_ branch September 23, 2024 14:43
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #4053 will improve performances by 30.39%

Comparing 09-23-perf_grit_use_to_ascii_lowercase_cow_ (48e38eb) with main (5df4e8b)

Summary

⚡ 1 improvements
✅ 106 untouched benchmarks

Benchmarks breakdown

Benchmark main 09-23-perf_grit_use_to_ascii_lowercase_cow_ Change
⚡ big5-added_15586211152145260264.json[uncached] 713.1 µs 546.9 µs +30.39%

@WomB0ComB0 WomB0ComB0 mentioned this pull request Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendjr arendjr arendjr approved these changes

Assignees
No one assigned
Labels
A-Parser Area: parser L-Grit Language: GritQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyc3 @arendjr