Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(linter): remove unneeded memory allocation for str #4142

Merged
merged 2 commits into from
Oct 1, 2024
Merged

perf(linter): remove unneeded memory allocation for str #4142

merged 2 commits into from
Oct 1, 2024

Conversation

togami2864
Copy link
Contributor

@togami2864 togami2864 commented Sep 30, 2024 •
edited
Loading

Summary

Removing unnecessary memory allocations for the performance

Test Plan

CI should pass

@github-actions github-actions bot added A-Linter Area: linter L-CSS Language: CSS labels Sep 30, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 30, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4142 will improve performances by 11.46%

Comparing togami2864:perf/css-rules (b99d9ad) with main (53f1420)

Summary

⚡ 1 improvements
✅ 100 untouched benchmarks

Benchmarks breakdown

Benchmark main togami2864:perf/css-rules Change
⚡ css_analyzer[bulma_5641719244145477318.css] 676.8 ms 607.2 ms +11.46%

@togami2864 togami2864 marked this pull request as ready for review October 1, 2024 12:28
@togami2864 togami2864 self-assigned this Oct 1, 2024
@Conaclos Conaclos merged commit f959987 into biomejs:main Oct 1, 2024
13 checks passed
@WomB0ComB0 WomB0ComB0 mentioned this pull request Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chansuke chansuke chansuke approved these changes

Assignees

@togami2864 togami2864

Labels
A-Linter Area: linter L-CSS Language: CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@togami2864 @chansuke @Conaclos