Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: order lint rules in rage output #4431

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

Conaclos
Copy link
Member

Summary

Order lint rules reported by biome rage.
This makes finding if a rule is enabled easier and avoids changes when we use a different hash function.

Test Plan

I updated the snapshots.

@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter labels Oct 30, 2024
@Conaclos Conaclos merged commit 1f33a17 into main Oct 30, 2024
11 checks passed
@Conaclos Conaclos deleted the conaclos/rage-sorted-rules branch October 30, 2024 11:20
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #4431 will degrade performances by 6.57%

Comparing conaclos/rage-sorted-rules (f4edd9e) with main (1b602dc)

Summary

❌ 1 regressions
✅ 98 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main conaclos/rage-sorted-rules Change
pure_9395922602181450299.css[cached] 3.4 ms 3.6 ms -6.57%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Linter Area: linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant