Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lint,actions): avoid duplicated filters #4434

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Conaclos
Copy link
Member

Summary

  • Use HashSet instead of Vec to avoid duplicated filters.
  • Remove get_disabled_rules for assist actions.
    In contrast to lint rules, as_enabled_rules doesn't need get_disabled_rules to compute enabled rules,
    because the system is simpler (no all and recommended flags)

Test Plan

CI must pass.

@github-actions github-actions bot added A-Project Area: project A-Tooling Area: internal tools labels Oct 30, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48421 48421 0
Passed 47221 47221 0
Failed 1200 1200 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6580 6580 0
Passed 2205 2205 0
Failed 4375 4375 0
Panics 0 0 0
Coverage 33.51% 33.51% 0.00%

ts/babel

Test result main count This PR count Difference
Total 680 680 0
Passed 607 607 0
Failed 73 73 0
Panics 0 0 0
Coverage 89.26% 89.26% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18518 18518 0
Passed 14178 14178 0
Failed 4340 4340 0
Panics 0 0 0
Coverage 76.56% 76.56% 0.00%

@Conaclos Conaclos merged commit d2b3b7f into main Oct 30, 2024
11 checks passed
@Conaclos Conaclos deleted the conaclos/enabled-rules-duplicas branch October 30, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Project Area: project A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants