-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geoserver e2e tests #381
Geoserver e2e tests #381
Conversation
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2070/Result : failure BIRDHOUSE_DEPLOY_BRANCH : geoserver-e2e-tests DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-216.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1314/NOTEBOOK TEST RESULTS |
@fmigneault |
Note component |
@tlvu Oh, I didn't realize that. From what I see, I could move my changes to another optional-component named Not sure what to do here since both of the PRs' modifications are conflicting, and my current PR works with the current version of birdhouse. If I apply changes before the other PR is merged, it will probably break my e2e tests. |
@ChaamC @tlvu @mishaschwartz I think the only difference is the current |
…geoserver-e2e-tests
# Overview This PR adds e2e tests for the access to different Geoserver resources and checks that the different user permissions from Magpie are respected. ## Changes - New notebook for geoserver tests ## Related Issue / Discussion - Related to Jira task [DAC-468](https://crim-ca.atlassian.net/browse/DAC-468) and PR [#381](bird-house/birdhouse-deploy#381) on birdhouse-deploy
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2112/Result : failure BIRDHOUSE_DEPLOY_BRANCH : geoserver-e2e-tests DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-216.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1342/NOTEBOOK TEST RESULTS |
…geoserver-e2e-tests
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2113/Result : failure BIRDHOUSE_DEPLOY_BRANCH : geoserver-e2e-tests DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-154.rdext.crim.ca Infrastructure deployment failed. Instance has not been destroyed. @matprov |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2114/Result : failure BIRDHOUSE_DEPLOY_BRANCH : geoserver-e2e-tests DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https:// Infrastructure deployment failed. Instance has not been destroyed. @matprov |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2115/Result : failure BIRDHOUSE_DEPLOY_BRANCH : geoserver-e2e-tests DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-154.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1344/NOTEBOOK TEST RESULTS |
@fmigneault @tlvu The other PR on Actually I was gonna tag PR #348 which contained the changes on the geoserver service, but I see that some changes were reverted and geoserver-secured is not deprecated anymore. Do I need to update anything else on the Also, received some errors/failures in some other e2e tests, but I don't think it is related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes it looks good on this end. But please on the Ouranosinc/PAVICS-e2e-workflow-tests#125 side, please do not enable that notebook as part of the default test suite so it does not run by default nightly on our production instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
#348 reverted changes related to deprecating test-geoserver-secured-access
to leave it available, so that it can be used as proposed in this PR.
The geoserver-secured
service however will be removed in favor of geoserver
standalone.
Shouldn't that be a config on the prod server to instead exclude this notebook from the test suite? |
Just saw Ouranosinc/PAVICS-e2e-workflow-tests#126. I'm fine with that workaround since the tests are indeed for validating auth in the case of GeoServer. Variable |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2119/Result : failure BIRDHOUSE_DEPLOY_BRANCH : geoserver-e2e-tests DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-46.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1346/NOTEBOOK TEST RESULTS |
Overview
Minor adjustments to the
test-geoserver-secured-access
component for the related e2e Geoserver testsChanges
test-geoserver-secured-access
Related Issue / Discussion