Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GitHub actions cmd check and code coverage #14

Merged
merged 24 commits into from
Oct 4, 2024

Conversation

SunnyTseng
Copy link
Collaborator

  • Added the CMD check and the code coverage into the GitHub actions workflow
  • The failed tests were fixed by running reticulate::install_python(version = "3.11") and birdnetR::install_birdnet(). All tests were successfully run locally.
  • Made sure there is a valid Python installation on the runner, and that reticulate knows to use it in GitHub Actions (instructions)
  • Try the Pull Request to initiate the Github Action and see how the tests go.

@kahst kahst requested a review from fegue August 15, 2024 06:31
@kahst
Copy link
Member

kahst commented Aug 15, 2024

Thanks @SunnyTseng , I'll let Felix do the review and merge, he's on vacation though, and it might take a while before we can proceed.

@SunnyTseng
Copy link
Collaborator Author

Thanks @kahst ! 🚀 There are still some error messages from the Github Action (R CMD check) that need to be addressed before merge. The devtools::check() can run without errors on my local computer, so I guess it's about the environment set up in the Github Action.

@fegue
Copy link
Member

fegue commented Sep 11, 2024

Hey Sunny, I am trying to get the custom model into the package as soon as possible. If thats done, I am going to take a look at this problem.
Thank you for your participation!

@fegue
Copy link
Member

fegue commented Sep 17, 2024

Yeah! Most checks work now :)

@fegue
Copy link
Member

fegue commented Sep 17, 2024

Actually, all checks work. I just have a few comments / questions in the code. See the review

Copy link
Member

@fegue fegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work. This is really helpful

.github/workflows/R-CMD-check.yaml Outdated Show resolved Hide resolved
.github/workflows/R-CMD-check.yaml Show resolved Hide resolved
.github/workflows/R-CMD-check.yaml Outdated Show resolved Hide resolved
R/birdnet_interface.R Outdated Show resolved Hide resolved
tests/testthat/helper.R Outdated Show resolved Hide resolved
@SunnyTseng
Copy link
Collaborator Author

Woohoo!! All checks have passed! I think this PR is ready to be merged! 🚀

@fegue
Copy link
Member

fegue commented Oct 4, 2024

Great! You can merge it when you are ready

@SunnyTseng SunnyTseng merged commit 18a1f0f into main Oct 4, 2024
6 checks passed
@SunnyTseng SunnyTseng deleted the setup-github-actions---CMD-check-and-code-coverage branch October 4, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants