Use STATIC_ITEM for static text #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
rc_birkett_info_menu
branch
from
e908050 to
60f05e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR MarlinFirmware#3662 adds a
STATIC_ITEMmacro toultralcd.cppthat works within the menu system to display a non-interactive line of static text. This gains us 2 spaces since there is no cursor display. The cursor still exists, so you can scroll the display. The cursor cannot move above the 4th display line (on a 4-line display). Thus, if you scroll to the top, there is no "dead spot" where it will not scroll.This also makes the feature optional, and disabled by default.
Since static items are non-interactive, we explicitly check for a click to return to status.