Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set List& Detail resources to Default BundleConfig #21

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

TheCadien
Copy link
Contributor

I moved the List & Detail path default Config in the Bundle Config.
Think it isnt really need to configure it by your self, should be cleaner.
And if it is there a reason for Change, the user could overwrite the config.

@shochdoerfer shochdoerfer added this to the 0.2.0 milestone Mar 29, 2023
@shochdoerfer
Copy link
Member

@TheCadien thx for this PR. Very much appreciated.

Will this cause trouble when upgrading and the yaml file is already in place? If yes, then we need to mark it as being a BC break.

@TheCadien
Copy link
Contributor Author

Feel free and can test it, but in my mind the old config yaml now simply overwrites the config in the bundle.
Which has no influence on the function but is simply superfluous.
A deprecation note in an Upgrade.md would be sufficient in my eyes.

@shochdoerfer shochdoerfer merged commit 524d7d1 into bitExpert:main Mar 29, 2023
@shochdoerfer
Copy link
Member

Will try to prepare a release in the next few days.

If you see other improvements, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants