Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup formatting checks and follow formatting guidelines #11

Merged
merged 6 commits into from
Aug 14, 2020

Conversation

MrNaif2018
Copy link
Member

@MrNaif2018 MrNaif2018 commented Aug 13, 2020

This PR removes pylint because of incompatibility with isort 5 and other bugs, upgrades isort to version 5, and formats all python code with it to comply to our coding guidelines.
To run all checks before committing, it is now possible to just run make command

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   62.82%   62.82%           
=======================================
  Files           9        9           
  Lines         347      347           
=======================================
  Hits          218      218           
  Misses        129      129           
Impacted Files Coverage Δ
bitcart/coins/btc.py 54.54% <61.53%> (ø)
bitcart/coins/bch.py 68.75% <66.66%> (ø)
bitcart/providers/jsonrpcrequests.py 68.25% <66.66%> (ø)
bitcart/coin.py 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57324b...ac02828. Read the comment docs.

@MrNaif2018 MrNaif2018 merged commit a1f6429 into master Aug 14, 2020
@MrNaif2018 MrNaif2018 deleted the formatting-setup branch August 14, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant